[PATCH] D71629: [SystemZ] Recognize mrecord-mcount in backend

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 18 10:56:16 PST 2019


uweigand added a comment.

Minor cosmetic comment, otherwise this LGTM.



================
Comment at: llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp:560
+    MCSymbol *DotSym = OutContext.createTempSymbol();
+    OutStreamer->EmitLabel(DotSym);
+    OutStreamer->PushSection();
----------------
I think it would be nicer to have the EmitLabel after the PopSection, so that the label is optically close to the instruction it labels.  But that's just cosmetics.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71629/new/

https://reviews.llvm.org/D71629





More information about the llvm-commits mailing list