[PATCH] D70570: [PowerPC] Only use PLT annotations if using PIC relocation model

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 18 08:18:59 PST 2019


sfertile added a comment.

In D70570#1789789 <https://reviews.llvm.org/D70570#1789789>, @jhibbits wrote:

> Update diff.  It would help if I actually compiled when rebasing...
>
> @sfertile I figured the available-externally.ll test would suffice for this.
>  Do you think a separate test is needed, or a comment is warranted on this
>  test for it?


I see the available externally test more as a test of that specific linkage type, but anyone that tried to update this behavior would need to modify that test, and see the comment so I'd be equally happy with either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70570/new/

https://reviews.llvm.org/D70570





More information about the llvm-commits mailing list