[PATCH] D69999: [DebugInfo] Support for DW_OP_implicit_pointer (IR Verifier and Bitcode)

[Alok Kumar Sharma via Phabricator via llvm-commits]

alok marked 6 inline comments as done.
alok added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicInst.h:128
+    bool isImplicitPointer() const {
+      if (!isa<DIExpression>(getRawExpression()))
+        return false;
----------------
StephenTozer wrote:
> I think this check is unnecessary - it seems like this is expected to be true for every DbgVariableIntrinsic, and this check isn't used anywhere else prior to calling getExpression().
Thanks for your comment. It will be incorporated in next version.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h:45
 
   /// Or a location in the machine frame.
   MachineLocation Loc;
----------------
StephenTozer wrote:
> Nit: the full stop should be replaced by a comma, and the comment immediately below should end with a full stop.
Thanks for your comment. It will be incorporated in next version.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h:135
+      return ImplicitVars.size() - 1;
+    } else
+      return std::distance(ImplicitVars.begin(), It);
----------------
StephenTozer wrote:
> The "else" can be removed, since the if block ends with a return statement.
Thanks for your comment. It will be incorporated in next release.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69999/new/

https://reviews.llvm.org/D69999