[PATCH] D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2)

[Anton Afanasyev via Phabricator via llvm-commits]

anton-afanasyev added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1754
 template <class ELFT> void LinkerDriver::link(opt::InputArgList &args) {
+  llvm::TimeTraceScope timeScope("Link");
   // If a -hash-style option was not given, set to a default value,
----------------
MaskRay wrote:
> I'd prefer `"LinkerDriver::link"`.
Unified scope name like "Link" is good for grouping blocks by `chrome://tracing` app. Isn't it better to put `"LinkerDriver::link"` to `Details` field of `timeScope`? (though this field is usually used for _user_ source code names, but here it is unused).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71060/new/

https://reviews.llvm.org/D71060