[PATCH] D71609: [ARM][MVE] Fixes for tail predication.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 18 00:57:18 PST 2019


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5212-5213
   bits<4> Rn;
   let isBranch = 0;
   let isTerminator = 0;
   let Inst{22-20} = 0b100;
----------------
I'm surprised we haven't need this earlier!

Can these 2 lines be be removed now?


================
Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/unsafe-cpsr-loop-use.mir:145
     early-clobber renamable $r0 = t2STR_PRE killed renamable $r3, killed renamable $r0, 4, 14, $noreg :: (store 4 into %ir.scevgep4)
+    renamable $lr = tMOVr $lr, 14, $noreg
     t2LoopEnd killed renamable $lr, %bb.1, implicit-def dead $cpsr
----------------
What's this about?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71609/new/

https://reviews.llvm.org/D71609





More information about the llvm-commits mailing list