[PATCH] D71592: [X86] Enable STRICT_FP_TO_SINT/UINT on X86 backend.

[LiuChen via Phabricator via llvm-commits]

LiuChen3 marked 2 inline comments as done.
LiuChen3 added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:19669
+          Res = DAG.getMergeValues({Res, Chain}, dl);
+        return DAG.getNode(ISD::EXTRACT_SUBVECTOR, dl, MVT::v2i1, Res,
+                           DAG.getIntPtrConstant(0, dl));
----------------
craig.topper wrote:
> If the IsStrict is taken, then this does an extract_subvector from a merge values and then deosn't return the chain. Are we missing test coverage? I think that should have triggered an assert.
I think I made a mistake here.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:28554
+          SDNodeFlags Flags;
+          Flags.setFPExcept(true);
+          Res->setFlags(Flags);
----------------
craig.topper wrote:
> Please add a FIXME here, setting this to true unconditionally will need to be fixed when we stop losing flags.
I forgot to delete.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71592/new/

https://reviews.llvm.org/D71592