[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

Tue Dec 17 11:51:34 PST 2019

jdoerfert added a subscriber: rjmccall.
jdoerfert added a comment.

In D70258#1788305 <https://reviews.llvm.org/D70258#1788305>, @rjmccall wrote:

> I opposed the creation of this library on these terms in the first place, so I'm pretty sure I'm not on the hook to review it.

That's fine with me.

> Introducing an IRBuilder-level finalization stack sounds like it's going to be a huge mess if your goal is to plug this into other frontends.

While I get that you don't want to review this, I would really like to understand why you think this would become a mess.

FWIW. The only code that is currently in Clang to make this work is going to be removed once the code generation is moved as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70258/new/

https://reviews.llvm.org/D70258