[PATCH] D69147: [gicombiner] Add support for arbitrary match data being passed from match to apply

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 11:16:04 PST 2019


dsanders marked an inline comment as done.
dsanders added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-concat-vectors.mir:22
+    ; CHECK: [[CONCAT_VECTORS:%[0-9]+]]:_(<4 x s64>) = G_CONCAT_VECTORS [[BUILD_VECTOR]](<2 x s64>), [[BUILD_VECTOR1]](<2 x s64>)
+    ; CHECK: RET_ReallyLR implicit [[CONCAT_VECTORS]](<4 x s64>)
     %0:_(s64) = COPY $x0
----------------
volkan wrote:
> These changes doesn't look relevant, could you double check?
Looks like it was caused by a bad rebase that lost the G_CONCAT_VECTORS case. I'm testing a fix for that and if all goes well I'll push this tomorrow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69147/new/

https://reviews.llvm.org/D69147





More information about the llvm-commits mailing list