[PATCH] D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 16 14:11:09 PST 2019


vsk added a comment.

In D70497#1785975 <https://reviews.llvm.org/D70497#1785975>, @TWeaver wrote:

> Essentially KILL instructions are NOOPs. They do not change the bit fields of any of the registers they touch. They merely adjust the liveness of a register or subregister to indicate to future consumers that the liveness of some value in a register has changed.
>  [snip]


Thanks for explaining, this makes sense to me. Any reason to not use `MI.isMetaInstruction()` as the guard? That would cause CFI/lifetime/EH_LABEL instructions to be skipped in addition to debug/kill instructions - would that be reasonable?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70497/new/

https://reviews.llvm.org/D70497





More information about the llvm-commits mailing list