[PATCH] D71462: [llvm-readelf][llvm-readobj] - Reimplement the logic of section flags dumping.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 01:26:18 PST 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one remaining nit.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/section-flags-os-proc.test:5
+
+## Here we test how OS and processor specific flags are dumped.
+
----------------
Shouldn't this be above the corresponding RUNs?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71462/new/

https://reviews.llvm.org/D71462





More information about the llvm-commits mailing list