[PATCH] D71582: llvm-diff: Perform structural comparison on GlobalVariables, if possible

[John McCall via Phabricator via llvm-commits]

rjmccall added a comment.

No, that's not true; something with External linkage would not trip any of those conditions normally.  ("Externally initialized" in particular is basically unrelated to linkage.)  I think you want a condition something like `L->getName() == R->getName() || (L->hasLocalLinkage() && R->hasLocalLinkage())`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71582/new/

https://reviews.llvm.org/D71582