[PATCH] D71564: [Attributor] H2S fix.

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 16 14:20:39 PST 2019


sstefan1 marked an inline comment as done.
sstefan1 added inline comments.


================
Comment at: llvm/test/Transforms/Attributor/heap_to_stack.ll:314
 
+define i32 @test_sle() {
+  %1 = tail call noalias i8* @malloc(i64 -1)
----------------
lebedev.ri wrote:
> sstefan1 wrote:
> > lebedev.ri wrote:
> > > Precommit the tests?
> > > https://godbolt.org/z/MG49m9
> > Just to make sure, you are suggesting to commit tests only first?
> > 
> > What is the difference, other than build bot failures?
> I'm not sure why would there be failures, that test does not trigger any assertions for me locally?
> (Obviously, checklines should be changed before commit)
Ok, I'll commit tests with modified check lines first. Unfortunately I'll have to do that tomorrow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71564/new/

https://reviews.llvm.org/D71564





More information about the llvm-commits mailing list