[PATCH] D71383: [LoopGuard] Instructions in loop preheader and loop exit must be safe to execute speculatively.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 16 09:57:37 PST 2019


fhahn added a comment.

In D71383#1784566 <https://reviews.llvm.org/D71383#1784566>, @Meinersbur wrote:

> I am ok with this patch. @fhahn what do you think?


I think the patch still misses a description of the motivation for the restriction in `getLoopGuardBranch`. I see why the restriction would be helpful for LoopFusion, but it seems like there could be other uses cases that do not require that restriction (e.g. if one wants to use the guard for reasoning about values in the loop).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71383/new/

https://reviews.llvm.org/D71383





More information about the llvm-commits mailing list