[PATCH] D71359: Fix assertion failure in getMemOperandWithOffsetWidth

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 16 07:20:40 PST 2019


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM, thanks @kristof.beyls!



================
Comment at: llvm/test/CodeGen/AArch64/machine-sink-getmemoperandwithoffset.mir:34
+body:             |
+  ; Just check that the pass didn't crash/assert.
+  ; CHECK-LABEL: name: g
----------------
kristof.beyls wrote:
> sdesmalen wrote:
> > nit: Can you add a comment clarifying which instruction (that is not a load or store) would have caused the assert to fail?
> I now added a comment that hopefully is useful for people reading this test in the future, see a few lines below.
Thanks, that comment seems useful to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71359/new/

https://reviews.llvm.org/D71359





More information about the llvm-commits mailing list