[PATCH] D71483: [AArch64][SVE] Add patterns for logical immediate operations.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 16 07:11:30 PST 2019


sdesmalen accepted this revision.
sdesmalen added a comment.

Thanks @dancgr, LGTM!

There is no harm in adding these intrinsics, but it is worth pointing out that our downstream compiler does not have explicit intrinsics for the immediate forms because:

- There are no specific C/C++ intrinsics that require the operand to be an immediate. That means using the immediate form is purely an optimisation of the general ((unpredicated) vector, vector) case.
- We can use a pattern to match e.g. the `AArch64dup (SVELogicalImm32 i64:$imm)` and emit the immediate-form of the instruction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71483/new/

https://reviews.llvm.org/D71483





More information about the llvm-commits mailing list