[PATCH] D71464: [llvm-readelf] - Change letters used for SHF_ARM_PURECODE and SHF_X86_64_LARGE flags.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnu-sections.test:1
+## In this test case we check how we print sections and flags description for different targets.
+
----------------
section and flag descriptions


================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnu-sections.test:4
+## EM_386 is a target that does not have any processor and OS specific flags,
+## we use it to show how the default key to flags help text is printed.
+
----------------
I'd probably delete the phrase "help text" here as it could be confused with the output of --help, and is unnecessary ("key" already implies its a descriptive piece of help text).

I'd also rephrase slightly:
"to show how the default flag key is printed."


================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnu-sections.test:7
 # RUN: yaml2obj --docnum=1 %s -o %t-i386.o
-# RUN: llvm-readelf -S %t-i386.o | FileCheck %s -check-prefix ELF32
+# RUN: llvm-readelf -S %t-i386.o | FileCheck %s -check-prefix ELF32 --strict-whitespace --match-full-lines
 
----------------
--check-prefix here and below.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnu-sections.test:61
 
+## For a EM_X86_64 target we print "l" for SHF_X86_64_LARGE section flag.
+## Check we mention it in tn the keys description text provided.
----------------
a EM_X86_64 -> an EM_X86_64
for the SHF_X86_64_LARGE


================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnu-sections.test:62
+## For a EM_X86_64 target we print "l" for SHF_X86_64_LARGE section flag.
+## Check we mention it in tn the keys description text provided.
+
----------------
Check we mention it in the flag key.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnu-sections.test:127
+
+## For a EM_ARM target we print "y" for SHF_ARM_PURECODE section flag.
+## Check we mention it in tn the keys description text provided.
----------------
a EM_ARM -> an EM_ARM
for the SHF_ARM_PURECODE


================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnu-sections.test:128
+## For a EM_ARM target we print "y" for SHF_ARM_PURECODE section flag.
+## Check we mention it in tn the keys description text provided.
+
----------------
Same comment as above.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/section-arch-flags.test:101
+
+## Despite of the fact that "lE" looks a bit strange, this matches the GNU order.
+# X86_64-GNU: [Nr] Name          Type     Address          Off    Size   ES Flg Lk Inf Al
----------------
Why does it look strange? (Also "Despite the fact...")


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71464/new/

https://reviews.llvm.org/D71464