[PATCH] D71521: Support for library function aligned_alloc

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D71521#1785308 <https://reviews.llvm.org/D71521#1785308>, @jdoerfert wrote:

> In D71521#1785299 <https://reviews.llvm.org/D71521#1785299>, @bondhugula wrote:
>
> > I think aligned_alloc will by itself really addresses a lot of use cases.
>
>
> Sure. Getting all of them, especially if there is almost no extra cost, is still worth it. Not everybody writes C11 and/or updated their code.


Note that C++17 `std::aligned_alloc()` defers to C11's `aligned_alloc()`.

In D71521#1785364 <https://reviews.llvm.org/D71521#1785364>, @bondhugula wrote:

> In D71521#1785308 <https://reviews.llvm.org/D71521#1785308>, @jdoerfert wrote:
>
> > In D71521#1785299 <https://reviews.llvm.org/D71521#1785299>, @bondhugula wrote:
> >
> > > In D71521#1785281 <https://reviews.llvm.org/D71521#1785281>, @jdoerfert wrote:
> > >
> > > > This test contains various changes in different parts of the code plus unrelated fixes (in comments, spelling, formatting, ...).
> > > >
> > > > I think it is beneficial to have a patch that recognizes aligned_alloc, which should be testable through existing calls to isAllocLike, and one that teaches the transformations about it. All the unrelated NFC changes can go in as NFC patches before hand and without pre-review. Generally speaking, smaller patches are good. More practically, you now need reviewers that accept changes in various places. Granted, the changes are not complex in nature, but the general logic still applies.
> > >
> >
>
>
> ...


I agree with @jdoerfert, there are several patches here:

- attributor,etc nfc changes
- some basic TLI/MemBuiltins changse
- attributor heap2stack changes
- gvn changes
- newgvn changes
- instcombine attribute deduction changes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71521/new/

https://reviews.llvm.org/D71521