[PATCH] D71523: [NFC] Simplify TargetLibraryInfo implementation

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 16 04:28:45 PST 2019


courbet added a comment.

This makes the code easier to read indeed, but this comes at the expense of allocations and less locality, so I would refrain from doing this unless we have a good reason.
Or: gather some data in the codebase as to whether a template-parametric `SmallBitVector` would find other usages, implement it, and use it here as a 3rd parameter to `PackedBitVector`.

Either way I don't have a strong opinion on the matter, but I'm pretty sure other people might, so please add other reviewers.



================
Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:396
+  TargetLibraryInfo &getTLI(const Function &F) {
+    (void)F;
     return TLI;
----------------
Do that in a separate patch ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71523/new/

https://reviews.llvm.org/D71523





More information about the llvm-commits mailing list