[PATCH] D71107: [ARM][MVE] Tail predicate in the presence of vcmp

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

One more nit about adding comments. This is a nice summary / description:

> This leaves us with several scenarios which need fixing up:
> 
> 1. A VPT block with is only predicated by the vctp and has no internal vpr defs.
> 2. A VPT block which is only predicated by the vctp but has an internal vpr def.
> 3. A VPT block which is predicated upon the vctp as well as another vpr def.
> 4. A VPT block which is not predicated upon a vctp, but contains it and all instructions within the block are predicated upon in.

Would be good to add that as a comment to `RecordVPTBlocks` ? Or add this where most appropiate...



================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:280
 
+static bool IsVPT(MachineInstr *MI) {
+  switch (MI->getOpcode()) {
----------------
In D71426, we came to the conclusion that these sort of helper functions should live ARMBaseInstrInfo :-)


================
Comment at: llvm/lib/Target/ARM/Utils/ARMBaseInfo.h:95
+
+  enum VPTMaskValue {
+    T     =  8, // 0b1000
----------------
Not important, you'd have noticed anyway, but in D71426 I've moved this to here already.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71107/new/

https://reviews.llvm.org/D71107