[llvm] d25db94 - [MC] Delete STT_SECTION special cases from MCSymbolELF::setType and setBinding

[Fangrui Song via llvm-commits]

Author: Fangrui Song
Date: 2019-12-15T20:39:25-08:00
New Revision: d25db94fa755651e42b15a51f2e8538f684418b7

URL: https://github.com/llvm/llvm-project/commit/d25db94fa755651e42b15a51f2e8538f684418b7
DIFF: https://github.com/llvm/llvm-project/commit/d25db94fa755651e42b15a51f2e8538f684418b7.diff

LOG: [MC] Delete STT_SECTION special cases from MCSymbolELF::setType and setBinding

The special cases added by rL293936 were no longer needed after rL296180
disallowed redefinition of section symbols.

Added: 
    

Modified: 
    llvm/lib/MC/MCSymbolELF.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/MC/MCSymbolELF.cpp b/llvm/lib/MC/MCSymbolELF.cpp
index a07c56c64f84..1830b87fd856 100644
--- a/llvm/lib/MC/MCSymbolELF.cpp
+++ b/llvm/lib/MC/MCSymbolELF.cpp
@@ -40,8 +40,6 @@ enum {
 
 void MCSymbolELF::setBinding(unsigned Binding) const {
   setIsBindingSet();
-  if (getType() == ELF::STT_SECTION && Binding != ELF::STB_LOCAL)
-    setType(ELF::STT_NOTYPE);
   unsigned Val;
   switch (Binding) {
   default:
@@ -93,8 +91,6 @@ unsigned MCSymbolELF::getBinding() const {
 
 void MCSymbolELF::setType(unsigned Type) const {
   unsigned Val;
-  if (Type == ELF::STT_SECTION && getBinding() != ELF::STB_LOCAL)
-    return;
   switch (Type) {
   default:
     llvm_unreachable("Unsupported Binding");