[PATCH] D71342: [sanitizer] Construct InternalMmapVector without memory allocation.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 15 19:54:02 PST 2019


ikudrin added a comment.

I'd like to note that this is not a purely theoretical issue. It can be observed, for example, in `Symbolizer::ModuleNameOwner` on a 64-bit platform with 4K memory pages. The default constructor for `storage_` allocates one memory page, which is immediately replaced by a new allocation in the call to `reserve()` for `1000` elements, which requires `8 * 1000 = 8000` bytes, or two pages.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71342/new/

https://reviews.llvm.org/D71342





More information about the llvm-commits mailing list