[PATCH] D71435: [WIP] [Attributor] Function level undefined behavior attribute

Stefanos Baziotis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 15 14:16:13 PST 2019


baziotis added a comment.

> You should either diff against the proper trunk revision you work on or merge all your commits into a single one. Right now you always only upload a diff against the last version of the patch.

My bad, I thought this is what I _had to_ do.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1993
+        if (!canCauseUB) {
+          noUBLoads.insert(I);
+        }
----------------
I couldn't find a way to save the entry so that we don't have to search the second (i.e. like in the unordered_map).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71435/new/

https://reviews.llvm.org/D71435





More information about the llvm-commits mailing list