[PATCH] D71480: [BasicBlockUtils] Fix dbg.value elimination problem in MergeBlockIntoPredecessor

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 15 06:27:58 PST 2019


bjope marked 2 inline comments as done.
bjope added inline comments.


================
Comment at: llvm/test/Transforms/SimplifyCFG/hoist-dbgvalue-inlined.ll:12
-; CHECK-NEXT:  call void @llvm.dbg.value(metadata i64 %vala, metadata [[MD]]
 ; CHECK-NEXT:  %valbmasked = and i64 %vala, 1
 
----------------
aprantl wrote:
> We might want to just delete the test now.
I looked a bit more at this. The test case does not seem totally useless. I think the original problem still could be detected. And now we also verify that we remove the redundant dbg.value for this kind of CFG simplification.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71480/new/

https://reviews.llvm.org/D71480





More information about the llvm-commits mailing list