[PATCH] D71168: [AArch64] Save FP for leaf functions when disabling frame pointer elimination

Sat Dec 14 09:50:40 PST 2019

MaskRay added a comment.

In D71168#1784849 <https://reviews.llvm.org/D71168#1784849>, @MaskRay wrote:

> In D71168#1784724 <https://reviews.llvm.org/D71168#1784724>, @thakis wrote:
>
> > This breaks tests on the "expensive tests" bot: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-debian/builds/514
> >
> > Please take a look!
>
>
> Looking. Where can I find the cmake configuration?
>
> Mine (`-DLLVM_ENABLE_ASSERTIONS=On -DLLVM_ENABLE_EXPENSIVE_CHECKS=On`) does not build for other reasons:
>
>   .../llvm/include/llvm/ADT/PointerUnion.h:93:26: error: constexpr variable 'NumLowBitsAvailable' must be initialized by
>    a constant expression                                                                                                                                
>       static constexpr int NumLowBitsAvailable = lowBitsAvailable<PTs...>();
>

I find the configuration in https://github.com/llvm/llvm-zorg/blob/master/buildbot/osuosl/master/config/builders.py and reproduce with `cmake -GNinja -Hllvm -BExpensive -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_EXPENSIVE_CHECKS=On -DLLVM_ENABLE_WERROR=Off -DCMAKE_CXX_FLAGS=-U_GLIBCXX_DEBUG`

Fixed in ccc453eb57b91a4e64ecfd7a9ee8d9415345c6b6 <https://reviews.llvm.org/rGccc453eb57b91a4e64ecfd7a9ee8d9415345c6b6>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71168/new/

https://reviews.llvm.org/D71168