[PATCH] D71496: [WebAssembly] Split and recombine multivalue calls for ISel

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 16:31:14 PST 2019


tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:462
                         WebAssembly::I64_TRUNC_U_F64);
-    llvm_unreachable("Unexpected instruction to emit with custom inserter");
   }
----------------
This `llvm_unreachable` truly is unreachable because it comes after the `return`. There is a default case at the top of the switch that contains another llvm_unreachable, so this one was both incorrect and redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71496/new/

https://reviews.llvm.org/D71496





More information about the llvm-commits mailing list