[PATCH] D71490: [lit] [windows] Make sure to convert all path separators to backslashes in NT style \\?\... paths

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 15:27:32 PST 2019


mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: llvm/utils/lit/lit/util.py:157
+            # NT path format only supports backslashes.
+            path = '\\'.join(path.split('/'))
             NTPath = to_unicode(r'\\?\%s' % path)
----------------
rnk wrote:
> I feel like path.replace('/', '\\') would be the more obvious spelling (fewer temporary strings), but they are functionally equivalent.
Ah, yes, will change it to that form before pushing the change. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71490/new/

https://reviews.llvm.org/D71490





More information about the llvm-commits mailing list