[PATCH] D58892: [ELF] Split RW PT_LOAD on the PT_GNU_RELRO boundary

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 13:00:20 PST 2019


mgorny added a comment.

In D58892#1783042 <https://reviews.llvm.org/D58892#1783042>, @MaskRay wrote:

> In D58892#1783029 <https://reviews.llvm.org/D58892#1783029>, @mgorny wrote:
>
> > I know I'm late to the party but this change thoroughly destroyed NetBSD support. The NetBSD loader doesn't support having more than two PT_LOAD sections. `-z norosegment` helped with that so far but after this change practically everything fails to run.
>
>
> This seems to be a very serious limitation. I have difficult to understand how such limitation could exist at all, but I think this should be straightforward to fix.


Yes, it is a serious limitation, and no, it's not straightforward to fix. The loader has making a lot of assumptions, especially what PT_LOAD segments to expect and in which order. I've previously made a patch that allowed third segment but it was rejected as apparently 'not doing it the right way'. Almost a year has passed, and I am entirely powerless to fix it.

> I presume you meant `--no-rosegment`, not `-z norosegment`. The latter does not exist.

Yes, whichever exists, I meant it ;-).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58892/new/

https://reviews.llvm.org/D58892





More information about the llvm-commits mailing list