[PATCH] D71132: PostRA Machine Sink should take care of COPY defining register that is a sub-register by another COPY source operand

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 10:06:32 PST 2019


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineSink.cpp:1284
+    LaneBitmask Mask;
+    for (MCSubRegIndexIterator S(SrcReg, TRI); S.isValid(); ++S) {
+      Mask |= TRI->getSubRegIndexLaneMask(S.getSubRegIndex());
----------------
Should use MCRegUnitMaskIterator instead of getting the lane masks for each subreg


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71132/new/

https://reviews.llvm.org/D71132





More information about the llvm-commits mailing list