[PATCH] D71358: AMDGPU: Remove denormal subtarget features
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 13 07:47:41 PST 2019
arsenm added a comment.
In D71358#1783418 <https://reviews.llvm.org/D71358#1783418>, @nhaehnle wrote:
> Would it be possible to do this patch in two steps:
>
> 1. First step: Add the parsing of the new function attribute, but keep the subtarget feature.
> 2. Second step: Remove the subtarget feature.
>
> This would make the upgrade process easier for out-of-tree users (Mesa, LLPC).
>
> Apart from that this seems like a good change to me.
That is basically how it’s split. Once the form of the attributes is finalized, frontends can start emitting the new form and we just won’t look it it until this patch
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71358/new/
https://reviews.llvm.org/D71358
More information about the llvm-commits
mailing list