[PATCH] D71348: Add ExternalAAWrapperPass to createLegacyPMAAResults.

Neil Henning via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 02:38:45 PST 2019


sheredom added a comment.

In D71348#1782253 <https://reviews.llvm.org/D71348#1782253>, @hfinkel wrote:

> In D71348#1779547 <https://reviews.llvm.org/D71348#1779547>, @sheredom wrote:
>
> > @nhaehnle just added you so that you are aware of this change - it in theory could minorly change codegen on AMDGPU but I think you don't actually return any more precise noaliasing state so it should (tm) be fine. But thought it was worth you oking this either way!
>
>
> Why would it change the AMDGPU backend? It looks like the AMDGPU backend does provide additional pointsToConstantMemory information via its AA implementation.


Yeah I'm pretty sure it won't - but you never know whether they had any additional stuff forked internally that this could affect, so felt it was better to make them aware!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71348/new/

https://reviews.llvm.org/D71348





More information about the llvm-commits mailing list