[PATCH] D71035: [llvm-objcopy][ELF] -O binary: use LMA instead of sh_offset to decide where to write section contents

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 02:35:14 PST 2019


jhenderson added a comment.

In D71035#1783026 <https://reviews.llvm.org/D71035#1783026>, @MaskRay wrote:

> Is it ok for me to commit if there is still no other people interested in this patch for, say, 10 hours?  😂
>
> I tested it on an internal `objcopy -I ihex -O binary` use case that motivated me to send the patch. With this patch, the section content layout is now the same.


Let's give it until after the weekend. We've been stung on a few occasions by issues with binary output, so I want to give people ample opportunity to point out anything else we've missed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71035/new/

https://reviews.llvm.org/D71035





More information about the llvm-commits mailing list