[PATCH] D71425: [llvm-cxxfilt] Correctly demangle COFF import thunk

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-cxxfilt/coff-import.test:7-8
+
+RUN: llvm-cxxfilt -n __imp__ZSt6futureIvE __imp__ZSt6futureIvE | \
+RUN:    FileCheck %s --check-prefix=CHECK-SPLIT
 
----------------
jhenderson wrote:
> This isn't a "split" demangling as you call it. This is two separate strings ("__imp__ZSt6futureIvE" and "__imp__ZSt6futureIvE"), which are individually demangled with no string splitting occurring. Did that case fail before?
> 
> I think what you need is `RUN: llvm-cxxfilt -n "__imp__ZSt6futureIvE __imp__ZSt6futureIvE"` so that the two names are treated as a single argument.
> ("impZSt6futureIvE" and "impZSt6futureIvE")

This should say ("`__imp__ZSt6futureIvE`" and "`__imp__ZSt6futureIvE`") but Phabricator refrormatted it...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71425/new/

https://reviews.llvm.org/D71425