[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

[Eric Astor via Phabricator via llvm-commits]

epastor added a comment.

Note: this currently breaks several test cases, at least some of which are valid.

Example: (minimized from ms-inline-asm-redundant-clobber.ll)
`call void asm inteldialect "cmpxchg8b $0", "=*m"(i32* @Bar)`
previously emitted
`cmpxchg8b Bar(%rip)`
and now (after the change to X86AsmPrinter.cpp) emits

  <inline asm>:2:29: error: unknown token in expression
          cmpxchg8b [rip + offset Bar]
                                     ^

I'm not sure how to fix this... but among other problems, it seems we've ended up emitting `offset` even when emitting AT&T-syntax assembly. (The same error occurs if we pass -x86-asm-syntax=intel, too.) This appears to affect all indirect memory operands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71436/new/

https://reviews.llvm.org/D71436