[PATCH] D71430: [llvm/runtimes] Add runtimes as a dependency of clang-bootstrap-deps

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 12 13:58:10 PST 2019


smeenai added subscribers: phosek, beanz, smeenai.
smeenai added reviewers: beanz, phosek, compnerd, smeenai.
smeenai added a comment.

This makes sense to me ... @beanz @phosek what do you think?



================
Comment at: llvm/runtimes/CMakeLists.txt:566
+      # We need to add the runtimes as a dependency because compiler-rt can be
+      # built as part of runtimes and we need it for PGO
+      add_dependencies(clang-bootstrap-deps runtimes)
----------------
I'd say "we need the profile runtime" instead of "we need it", just to be a bit more specific.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71430/new/

https://reviews.llvm.org/D71430





More information about the llvm-commits mailing list