[PATCH] D71360: Honor -fuse-init-array when os is not specified on x86

Thu Dec 12 10:51:14 PST 2019

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

So, this will lead to llc using .init_array by default, because llc doesn't know which ELF targets default to ctors, but clang does. See @maskray's clang change. I'm OK with that.

This looks good to me, but I would like to get a second approval from any of the other listed reviewers.

================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:93
 //===----------------------------------------------------------------------===//
-
 void TargetLoweringObjectFileELF::Initialize(MCContext &Ctx,
----------------
This whitespace change seems unnecessary, this is not a function doc comment, there should be a blank line here.

================
Comment at: llvm/lib/Target/X86/X86TargetObjectFile.h:52

-  /// X86FreeBSDTargetObjectFile - This implementation is used for FreeBSD
-  /// on x86 and x86-64.
----------------
Oh, wow, what a simplification. :)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71360/new/

https://reviews.llvm.org/D71360