[PATCH] D71411: [yaml2obj] - Add a way to override sh_flags section field.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 12 05:56:06 PST 2019


jhenderson added a comment.

This looks fine to me. I do have one question though: is it possible to allow Flags to take two different kinds of value (i.e. a list or a number)? If so, we don't need an extra field - if a number is specified, then use that and do no validation, otherwise try to map the list values to the flags and do validation. The other fields make sense because they allow overriding a value which is also used for something else (e.g. ShOffset allows overriding the section's offset, but the actual offset is still used for writing data).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71411/new/

https://reviews.llvm.org/D71411





More information about the llvm-commits mailing list