[PATCH] D71086: Let PassBuilder Expose PassInstrumentationCallbacks

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

Overall I'm fine with this.
Bikeshedding-wise, getPIC seems to be overly cryptic to me.
Do you believe full name getPassInstrumentationCallbacks is too much?

Also, please, add at least one test.
I would start with llvm/unittests/IR/PassBuilderCallbacksTest.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71086/new/

https://reviews.llvm.org/D71086