[PATCH] D66283: [llvm-objcopy][MachO] Implement --add-section

Seiya Nuta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 11 21:32:20 PST 2019


seiya added a comment.

In D66283#1779295 <https://reviews.llvm.org/D66283#1779295>, @jhenderson wrote:

> There seems to be some stuff to do with 64-bit versus normal segments in here, which I don't fully follow due to it being Mach-O, but your test only seems to handle the 64-bit segment type. Should it be extended?


I forgot to implement 32-bit support. The latest patch includes 32-bit support and tests for it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66283/new/

https://reviews.llvm.org/D66283





More information about the llvm-commits mailing list