[PATCH] D70606: LLD: CET shadow stack support on Windows

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

In D70606#1780090 <https://reviews.llvm.org/D70606#1780090>, @penzn wrote:

> In D70606#1778998 <https://reviews.llvm.org/D70606#1778998>, @ruiu wrote:
>
> > Could you tell me about how you generated has_cet.exe? I wonder if there's a way to create an executable in the test instead of submitting a binary file to the repository.
>
>
> It is a dummy executable (along the lines of `int main() {return 0;}`) built with Visual Studio 2019. This was inspired by the existing `llvm-readobj` PDB test which checks `has_pdb.exe`.
>
> In D70606#1779258 <https://reviews.llvm.org/D70606#1779258>, @jhenderson wrote:
>
> > On this topic, yaml2obj has COFF support, although I don't know if that's sufficient for your use case here.
>
>
> `yaml2obj` does not yet have CET flag support. What is the preferred path in this situation? We can add it, but it would be only used in this test.


I'd prefer enhancing yaml2obj tool so that it can emit the extended characteristics field if it is not too hard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70606/new/

https://reviews.llvm.org/D70606