[PATCH] D71298: [AArch64][SVE] Add patterns for scalable vselect

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 11 15:06:39 PST 2019


cameron.mcinally marked an inline comment as done.
cameron.mcinally added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-select.ll:20
+; CHECK-LABEL: sel_nxv8i16:
+; CHECK:       // %bb.0:
+; CHECK-NEXT:    mov z0.h, p0/m, z1.h
----------------
cameron.mcinally wrote:
> sdesmalen wrote:
> > nit: the check for the basic-block seems unnecessary.
> I can hand edit these if everyone wants that.
llvm-dev says that this is the intended behavior. The fix is to put the function declaration on one line. That seems a little excessive for a case like this though. 

I'll manually edit the CHECK lines and remove the automatic header note...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71298/new/

https://reviews.llvm.org/D71298





More information about the llvm-commits mailing list