[PATCH] D70720: [llvm-objdump] Display locations of variables alongside disassembly

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard updated this revision to Diff 233388.
ostannard marked 3 inline comments as done.
ostannard added a comment.

- Made suggested changes to tests. I've enabled strict whitespace checking just for the one test in which we check compatibility with other options which affect the layout of the output, because the disassembly uses tabs in a way which doesn't always display well in text editors.
- `getLocations` now works correctly with -ffunction-sections, so removed the workaround
- Removed unused parameters related to `DW_AT_frame_base`
- Get endianness form the `DWARFunit`, no need to pass it around separately
- Don't create/destroy formatted_raw_ostream as often


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70720/new/

https://reviews.llvm.org/D70720

Files:
  llvm/docs/CommandGuide/llvm-objdump.rst
  llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h
  llvm/include/llvm/Support/FormattedStream.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDie.cpp
  llvm/lib/Support/FormattedStream.cpp
  llvm/test/tools/llvm-objdump/ARM/Inputs/debug.c
  llvm/test/tools/llvm-objdump/ARM/debug-vars-dwarf4-sections.s
  llvm/test/tools/llvm-objdump/ARM/debug-vars-dwarf4.s
  llvm/test/tools/llvm-objdump/ARM/debug-vars-dwarf5-sections.s
  llvm/test/tools/llvm-objdump/ARM/debug-vars-dwarf5.s
  llvm/test/tools/llvm-objdump/PowerPC/debug-vars.s
  llvm/test/tools/llvm-symbolizer/frame-loclistx.s
  llvm/tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70720.233388.patch
Type: text/x-patch
Size: 100702 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191211/c67f5d45/attachment-0001.bin>