[PATCH] D71101: [lld][RISCV] Use an e_flags of 0 if there are only binary input files.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/test/ELF/riscv-binary.s:1
+# REQUIRES: riscv
+
----------------
MaskRay wrote:
> The test should probably be added into format-binary.test.
> 
> Also change riscv to x86. I think @grimar has concerns about common tests with an uncommon target requirement.
This test touches logic in `RISCV::calcEFlags()`, i.e. it is RISC-V specific, so I am fine with `# REQUIRES: riscv`

But I wonder if we want to have something more generic as a rest name rather than `riscv-binary.s`?
For example, I have not found tests for "cannot link object files with different floating-point ABI" or
"cannot link object files with different EF_RISCV_RVE" error messages. I think we might want to add a test
named "riscv-eflags" or alike and test this case there (assuming at one day somebody will
add missing tests for errors there).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71101/new/

https://reviews.llvm.org/D71101