[PATCH] D71323: [profile] Avoid allocating a page on the stack, NFC

[Vedant Kumar via Phabricator via llvm-commits]

vsk marked an inline comment as done.
vsk added a comment.

Thanks for the reviews!



================
Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:136
+            (sizeof(uint64_t) > BytesToWrite) ? BytesToWrite : sizeof(uint64_t);
+        if (fwrite(Zeroes, sizeof(uint8_t), PartialWriteLen, File) !=
+            PartialWriteLen) {
----------------
MaskRay wrote:
> `sizeof(uint8_t)` -> 1 ?
That's a reasonable alternative. However the current convention in libprofile is to write out the `sizeof`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71323/new/

https://reviews.llvm.org/D71323