[PATCH] D71246: [llvm-readobj][llvm-readelf] - Remove excessive empty lines when reporting errors and warnings.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 11 00:13:35 PST 2019


grimar added a comment.

In D71246#1777679 <https://reviews.llvm.org/D71246#1777679>, @jhenderson wrote:

> On the surface, this change looks fine to me. Have you checked that there are no more cases in the code where a warning can be reported in the middle of a line?


I reviewed them briefly and did not find anything obviously suspicious. Since we are going to switch to reporting unique warnings everywhere (right?),
then any such places will be revealed anyways in case they still are not covered by our tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71246/new/

https://reviews.llvm.org/D71246





More information about the llvm-commits mailing list