[PATCH] D71238: Align non-fused branches within 32-Byte boundary (basic case)

annita.zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 21:55:26 PST 2019


annita.zhang added a comment.

In D71238#1777857 <https://reviews.llvm.org/D71238#1777857>, @jyknight wrote:

> > Honestly, I both strongly agree with this, and see the argument as a somewhat lost cause. I think in practical terms, we *will* have to support something which works for both compiler generated assembly and legacy hand written assembly. I dislike that fact and the design it encourages, but it's reality.
>
> Hand-written assembly is generally responsible for its own performance optimizations, and we do not usually expect the assembler to muck around with the code. So, why is it assumed that _this_ optimization should be done automatically on such assembly code?


I think we need to think about those legacy assembly codes, and libraries written in assembly etc. If they are impacted by the microcode update, the assembler can provide a quick way to mitigate it w/o any code change. Why don't we do it? At least we can give users the option to use it or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71238/new/

https://reviews.llvm.org/D71238





More information about the llvm-commits mailing list