[PATCH] D71060: [LLD][ELF] Add time-trace to ELF LLD (2/2)

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/Driver.cpp:533
+    SmallString<128> path(config->outputFile);
+    llvm::sys::path::replace_extension(path, "json");
+    if (!args.getLastArgValue(OPT_time_trace_eq).empty())
----------------
I think it is better to make -time-trace to just print the result to stdout, as it is convenient.


================
Comment at: lld/ELF/Driver.cpp:979
+  config->timeTraceGranularity =
+      args::getInteger(args, OPT_time_trace_granularity, 500u);
   config->trace = args.hasArg(OPT_trace);
----------------
Is u prefix supported?

edit: Oh, this is not for nanosecond but just an unsigned. I'd just remove `u`.


================
Comment at: lld/ELF/Driver.cpp:1624
 template <class ELFT> void LinkerDriver::compileBitcodeFiles() {
+  llvm::TimeTraceScope timeScope("LTO", StringRef(""));
   // Compile bitcode files and replace bitcode symbols.
----------------
I'm curious what is supposed to pass as a second argument.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71060/new/

https://reviews.llvm.org/D71060