[PATCH] D59780: Support Intel Control-flow Enforcement Technology

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 17:05:06 PST 2019


MaskRay added a comment.

In D59780#1778623 <https://reviews.llvm.org/D59780#1778623>, @xiangzhangllvm wrote:

> In D59780#1738474 <https://reviews.llvm.org/D59780#1738474>, @ruiu wrote:
>
> > This patch is outdated and needs rebasing. I'll rebase, upload it again and then submit.
>
>
> Hi ruiu, just remind, if you have no time, I can rebase it.


I can do that, too, and cleaning the test.



================
Comment at: lld/test/ELF/x86-64-cet.s:44
+# DISASM:      0000000000201010 .plt:
+# DISASM-NEXT: 201010:       ff 35 f2 1f 00 00       pushq   8178(%rip)
+# DISASM-NEXT: 201016:       ff 25 f4 1f 00 00       jmpq    *8180(%rip)
----------------
These instructions should be aligned.

llvm-objcopy<9 may have alignment problems.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59780/new/

https://reviews.llvm.org/D59780





More information about the llvm-commits mailing list