[llvm] 4ffd3f4 - DebugInfo: Clarify some more reasons v4 loc.dwo can't share much implementation with loclists.dwo

[David Blaikie via llvm-commits]

Author: David Blaikie
Date: 2019-12-10T14:11:03-08:00
New Revision: 4ffd3f44e34283506958263a7f9eb2c9d149087f

URL: https://github.com/llvm/llvm-project/commit/4ffd3f44e34283506958263a7f9eb2c9d149087f
DIFF: https://github.com/llvm/llvm-project/commit/4ffd3f44e34283506958263a7f9eb2c9d149087f.diff

LOG: DebugInfo: Clarify some more reasons v4 loc.dwo can't share much implementation with loclists.dwo

Added: 
    

Modified: 
    llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
index 4def44cd776b..1e12b39a9784 100644
--- a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
@@ -2539,6 +2539,8 @@ void DwarfDebug::emitDebugLocDWO() {
       Asm->emitInt8(dwarf::DW_LLE_startx_length);
       unsigned idx = AddrPool.getIndex(Entry.Begin);
       Asm->EmitULEB128(idx);
+      // Also the pre-standard encoding is slightly 
diff erent, emitting this as
+      // an address-length entry here, but its a ULEB128 in DWARFv5 loclists.
       Asm->EmitLabelDifference(Entry.End, Entry.Begin, 4);
       emitDebugLocEntryLocation(Entry, List.CU);
     }