[PATCH] D71030: Tighten the check for Tool name ( ar, nm, dlltool, lib)

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 12:28:43 PST 2019


rupprecht added a comment.

In D71030#1769588 <https://reviews.llvm.org/D71030#1769588>, @MaskRay wrote:

> Oh, I think this may break `llvm-dlltool.exe` and `llvm-ar.exe` on Windows. We probably need a more sophisticated heuristic.


Does `sys::path::stem(ToolName)` convert `llvm-dlltool.exe` to `llvm-dlltool`? I don't have a Windows machine to check with, but it looks like it *might*.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71030/new/

https://reviews.llvm.org/D71030





More information about the llvm-commits mailing list