[PATCH] D68092: [AMDGPU] Invert the handling of skip insertion.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 08:34:21 PST 2019


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with grammar fix, although this isn't complete. There's still work to kill the existing pass



================
Comment at: lib/Target/AMDGPU/SIRemoveShortExecBranches.cpp:12
+/// The pass removes this skip instruction for short branches,
+/// if there is no unwanted sideeffects in the fallthrough code sequence.
+///
----------------
s/is no unwanted sideeffects/are no unwanted side effects/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68092/new/

https://reviews.llvm.org/D68092





More information about the llvm-commits mailing list